Blog talk:Adnoam/Updates to Template:Item/@comment-45466721-20200820203304

Fantastic work. I'm glad the Upper River Exchange is getting systematic treatment, it's something that's been needed. One thing I noticed was the messages: the Mask has explicit "no message" in the Bazaar table, and nothing in the Upper River table. Meanwhile the Potion has a blank (rather than "no message") in the Upper River selling, and the Eolith doesn't have the column at all. I realize that this is currently based on whether the Template parameter is not filled in or provided with an exclicit "no message." This could be addressed by setting defaults for those parameters.

I have some concerns about the Best-in-Slot logic. There's a rather substantial collection of edge-cases. You carved out an exception for non-Fate. What about non-Fate but mutually-exclusive rewards like Profession items or Ambition rewards? What about retired items? What about seasonal rewards? What about a Fate reward that's better than any non-Fate reward but not best-in-slot? (Example of the last is missionary & firebrand spouses.)

I'm also not sure we want to be encouraging judging equipment solely by whether it's best-in-slot, but I'll admit that's what a lot of the readership of the wiki probably is looking for.