Blog talk:Adnoam/Updates to Template:Item/@comment-45466721-20200820203304/@comment-25219384-20200820221757
Regarding buy/sell messages: The parameters I've added for the Upper River Exchange work exactly like they counterparts in the regular Bazaar. If we don't know whether there's a message or not, it's left empty, and the column isn't shown in the table. If we no that there's no message, we add "(no message)". I didn't go to try buying/selling all the items to find out if there is a message or not. But the template will accept the values, as usually.
In short, if you *know* that an item has no buy message at the Upper River Exchange, just add to the template the parameter
|Upper Buy Message = (no message)
or even simpler:
|Upper Buy Message =
(i.e. the parameter name with no content), and the same for Sell Message.
Regarding best-in-slot: Indeed there are many corner cases and in my opinion the vast majority of them are irrelevant for this purpose. The main quality item pages (e.g. Watchful Items) already give all of this data and all the permutations of useful qualifiers.
What I tried to add here is a quick note on an item's page to indicate it's the best of its class at something. Not "the best of its class if you didn't choose Nemesis", and not "the best of its class if you're not a Silverer". It's not meant to be personalized, and therefore I avoid the complications of adhering to all possible cases.
If we list that an item has Respectable +4, that's nice. If we can also easily signal that this happens to be best-in-slot, then this is useful information for the reader of the page - this might be the deciding factor for them whether to get this item (even if it's for a different profession than they have, or if it's only available during a specific holiday, for example).
I did decide on two special cases:
- Fate: since not everyone can/will spend real money on items and so it's - again - useful information to know that the item is best in slot among non-Fate items of that class.
- Moods: Unless taking this into account, no other Hat will be considered best-in-slot in the main stats, and that's a shame. So my code will take this into account.
I don't know of retired items which are best in slot in anything. If there are, I'll change the code to ignore them.
I don't understand the point about the Missionary/Firebrand spouses. Why are they not best in slot?
